Skip to content

add PR comment on ci false, switch manifestimage setting to if block#394

Merged
aptalca merged 4 commits intomonthlyfrom
pr-comment
Apr 17, 2026
Merged

add PR comment on ci false, switch manifestimage setting to if block#394
aptalca merged 4 commits intomonthlyfrom
pr-comment

Conversation

@aptalca
Copy link
Copy Markdown
Member

@aptalca aptalca commented Apr 16, 2026

  • Moving the PR comment block to post section required us to define run conditions very specifically. We previously accounted for CI test attempt, but failed to account for when CI tests are disabled in the main if condition. This PR accounts for the scenario where CI tests are disabled, but the build progressed to the push stage by introducing a stage set var PUSH_ATTEMPTED.
  • Changes a conditional block in manifest image generation to a proper if block with the var wrapped in double quotes. The main reason was cosmetic as the missing quotes messed up the code rendering of the rest of the jenkinsfile template.
  • Implements a PR comment message with a commit link when a build fails before reaching CI test or image push stages.

@aptalca aptalca requested review from a team April 16, 2026 15:19
@LinuxServer-CI LinuxServer-CI moved this to PRs Ready For Team Review in Issue & PR Tracker Apr 16, 2026
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-43a7ed47fb19c775b3dd88221d90dc5a2f70fd5f-pr-394/index.html
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-43a7ed47fb19c775b3dd88221d90dc5a2f70fd5f-pr-394/shellcheck-result.xml

Tag Passed
amd64-beac3828-pkg-beac3828-dev-43a7ed47fb19c775b3dd88221d90dc5a2f70fd5f-pr-394
arm64v8-beac3828-pkg-beac3828-dev-43a7ed47fb19c775b3dd88221d90dc5a2f70fd5f-pr-394

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-29e9d5f837f73e403be44223ef1484fc5cc96b92-pr-394/index.html
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-29e9d5f837f73e403be44223ef1484fc5cc96b92-pr-394/shellcheck-result.xml

Tag Passed
amd64-beac3828-pkg-beac3828-dev-29e9d5f837f73e403be44223ef1484fc5cc96b92-pr-394
arm64v8-beac3828-pkg-beac3828-dev-29e9d5f837f73e403be44223ef1484fc5cc96b92-pr-394

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR for commit 07c2352 :
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-07c2352038be9005c0362c84e0ac3ff8ca9a608b-pr-394/index.html
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-07c2352038be9005c0362c84e0ac3ff8ca9a608b-pr-394/shellcheck-result.xml

Tag Passed
amd64-beac3828-pkg-beac3828-dev-07c2352038be9005c0362c84e0ac3ff8ca9a608b-pr-394
arm64v8-beac3828-pkg-beac3828-dev-07c2352038be9005c0362c84e0ac3ff8ca9a608b-pr-394

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR for commit 8b79308 :
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-8b79308a489771484db0715a83d5d597706c2ef8-pr-394/index.html
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-8b79308a489771484db0715a83d5d597706c2ef8-pr-394/shellcheck-result.xml

Tag Passed
amd64-beac3828-pkg-beac3828-dev-8b79308a489771484db0715a83d5d597706c2ef8-pr-394
arm64v8-beac3828-pkg-beac3828-dev-8b79308a489771484db0715a83d5d597706c2ef8-pr-394

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, the build for PR commit e4cf6f6 failed and as a result no CI test was attempted and no images were pushed.

@aptalca aptalca mentioned this pull request Apr 16, 2026
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR for commit 8e764f1 :
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-8e764f1bb8e2a72acc6787c99f5a38018fecdbcf-pr-394/index.html
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/beac3828-pkg-beac3828-dev-8e764f1bb8e2a72acc6787c99f5a38018fecdbcf-pr-394/shellcheck-result.xml

Tag Passed
amd64-beac3828-pkg-beac3828-dev-8e764f1bb8e2a72acc6787c99f5a38018fecdbcf-pr-394
arm64v8-beac3828-pkg-beac3828-dev-8e764f1bb8e2a72acc6787c99f5a38018fecdbcf-pr-394

@github-project-automation github-project-automation Bot moved this from PRs Ready For Team Review to PRs Approved in Issue & PR Tracker Apr 16, 2026
@aptalca aptalca merged commit 015d9b1 into monthly Apr 17, 2026
4 checks passed
@aptalca aptalca deleted the pr-comment branch April 17, 2026 10:25
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants